Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build(deps-dev): Bump the bundler-dev group with 2 updates #3706

Closed
wants to merge 1 commit into from
Closed

Build(deps-dev): Bump the bundler-dev group with 2 updates #3706

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 22, 2023 •
edited
Loading

Bumps the bundler-dev group with 2 updates: factory_bot_rails and rspec-rails.

Updates factory_bot_rails from 6.2.0 to 6.4.0

Release notes

Sourced from factory_bot_rails's releases.

6.4.0

No release notes provided.

6.3.0

  • Changed: reject sequence definitions for ActiveRecord primary keys (Sean Doyle).
  • Changed: factory_bot dependency to ~> 6.4 (Mike Burns).
  • Changed: upgrade dependencies (Daniel Colson).
  • Add: projections.json for Rails.vim (Caleb Hearth).
  • Docs: fix broken link (Edu Depetris).
  • Docs: mention Rails generator in docs (Edu Depetris).
  • Docs: fix typo (Yudai Takada).
  • Internal: skip Spring version 2.1.1 due to a bug in that release (Christina Entcheva, Daniel Colson).
  • Internal: test against Rails 6.1 (Antonis Berkakis).
  • Internal: test against Ruby 3 (Daniel Colson).
  • Internal: fewer warnings in Cucumber tests (Daniel Colson).
  • Internal: use GitHub Actions for CI (Mathieu Jobin).
  • Internal: a whole bunch of cleanup (Daniel Colson).
  • Internal: fix CI due to a Bundler output change (Mike Burns).
Changelog

Sourced from factory_bot_rails's changelog.

6.4.0 (November 17, 2023)

  • Releasing this for consistency with the factory_bot dependency.

6.3.0 (November 17, 2023)

  • Changed: reject sequence definitions for ActiveRecord primary keys (Sean Doyle).
  • Changed: factory_bot dependency to ~> 6.4 (Mike Burns).
  • Changed: upgrade dependencies (Daniel Colson).
  • Add: projections.json for Rails.vim (Caleb Hearth).
  • Docs: fix broken link (Edu Depetris).
  • Docs: mention Rails generator in docs (Edu Depetris).
  • Docs: fix typo (Yudai Takada).
  • Internal: skip Spring version 2.1.1 due to a bug in that release (Christina Entcheva, Daniel Colson).
  • Internal: test against Rails 6.1 (Antonis Berkakis).
  • Internal: test against Ruby 3 (Daniel Colson).
  • Internal: fewer warnings in Cucumber tests (Daniel Colson).
  • Internal: use GitHub Actions for CI (Mathieu Jobin).
  • Internal: a whole bunch of cleanup (Daniel Colson).
  • Internal: fix CI due to a Bundler output change (Mike Burns).
Commits
  • 3346305 Bump to 6.4.0 [ci skip]
  • 438d035 Bump to 6.3.0 [ci skip]
  • f9a1e7c Depend on factory_bot 6.4.x
  • fd1ca67 s/eser/user/ (#422)
  • 659d74a Add projections.json for Rails.vim support
  • 0040292 Reject sequence definitions for Active Record primary keys (#419)
  • a28bec8 Bundler 2.4.19 removed the "Using " lines
  • 3995e62 Add custom Rails generator in README.md [ci skip]
  • a0adccc Remove references to travis
  • 30c85d5 Expand matrix for more recent versions
  • Additional commits viewable in compare view

Updates rspec-rails from 6.0.3 to 6.1.0

Changelog

Sourced from rspec-rails's changelog.

6.1.0 / 2023-11-21

Full Changelog

Enhancements:

  • Support for Rails 7.1
  • Minor tweak to generated rails_helper.rb to use Rails.root.join. (@​masato-bkn, Ryo Nakamura, #2640, #2678)
  • Add RSpec::Rails::Configuration.fixture_paths configuration to support the matching change to ActiveRecord::TestFixtures, previous singular form is deprecated and will be removed in Rails 7.2. (Juan Gueçaimburu, #2673)
  • Add send_email matcher to match emails rather than specific jobs. (Andrei Kaleshka, #2670)
  • When using render in view specs, :locals will now be merged into the default implicit template, allowing render locals: {...} style calls. (Jon Rowe, #2686)
  • Add support for Rails.config.action_mailer.preview_paths on Rails 7.1/ (Jon Rowe, #2706)

6.0.4 / 2023-11-21

Full Changelog

Bug Fixes:

  • Fuzzy match have_broadcasted_to so that argument matchers can be used. (Timothy Peraza, #2684)
  • Fix fixture warning during :context hooks on Rails main. (Jon Rowe, #2685)
  • Fix stub_template on Rails main. (Jon Rowe, #2685)
  • Fix variable name in scaffolded view specs when namespaced. (Taketo Takashima, #2694)
  • Prevent take_failed_screenshot producing an additional error through metadata access. (Jon Rowe, #2704)
  • Use ActiveSupport::ExecutionContext::TestHelper on Rails 7+. (Jon Rowe, #2711)
  • Fix leak of templates stubbed with stub_template on Rails 7.1. (Jon Rowe, #2714)
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@just1602
Copy link
Collaborator

We should wait for thoughtbot/factory_bot_rails#425 and thoughtbot/factory_bot_rails#432 to be fixed before upgrading factory_bot_rails again.

Since it's a grouped PR I'll wait for dependabot to superseed it since I don't want to skip the rspec-rails update.

@dependabot @just1602
Build(deps-dev): Bump the bundler-dev group with 2 updates
6ec2ce2 
Bumps the bundler-dev group with 2 updates: [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) and [rspec-rails](https://github.com/rspec/rspec-rails).


Updates `factory_bot_rails` from 6.2.0 to 6.4.0
- [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases)
- [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md)
- [Commits](thoughtbot/factory_bot_rails@v6.2.0...v6.4.0)

Updates `rspec-rails` from 6.0.3 to 6.1.0
- [Release notes](https://github.com/rspec/rspec-rails/releases)
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md)
- [Commits](rspec/rspec-rails@v6.0.3...v6.1.0)

---
updated-dependencies:
- dependency-name: factory_bot_rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: bundler-dev
- dependency-name: rspec-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: bundler-dev
...

Signed-off-by: dependabot[bot] <[email protected]>
@just1602 just1602 force-pushed the dependabot/bundler/bundler-dev-611ffd5f83 branch from 7fbe541 to 6ec2ce2 Compare November 22, 2023 05:37
@just1602
Copy link
Collaborator

@dependabot update

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 24, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@just1602
Copy link
Collaborator

@dependabot recreate

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 24, 2023

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Nov 24, 2023
@dependabot dependabot bot deleted the dependabot/bundler/bundler-dev-611ffd5f83 branch November 24, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just1602 just1602 just1602 approved these changes

@astronaut-wannabe astronaut-wannabe Awaiting requested review from astronaut-wannabe astronaut-wannabe is a code owner

@bookis bookis Awaiting requested review from bookis bookis is a code owner

@eliduke eliduke Awaiting requested review from eliduke eliduke is a code owner

@evanphx evanphx Awaiting requested review from evanphx evanphx is a code owner

@guitsaru guitsaru Awaiting requested review from guitsaru guitsaru is a code owner

@veganstraightedge veganstraightedge Awaiting requested review from veganstraightedge veganstraightedge is a code owner

Assignees
No one assigned
Labels
🕸️ dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@just1602